Skip to content

Modernize bs4 interface #20415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

Modernize bs4 interface #20415

merged 2 commits into from
Jun 23, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

What does this PR do?

This PR resolves the deprecation warnings of the bs4 library:

DeprecationWarning: Call to deprecated method findAll. (Replaced by find_all) -- Deprecated since version 4.0.0.

It fixes a typo along the way.

Motivation

CI logs throw those warnings.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.54%. Comparing base (09df43f) to head (17d7aba).
Report is 111 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
spark 93.20% <0.00%> (-0.31%) ⬇️
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuel-ferdman thanks a bunch for the contribution!

Let me know if you need help adding a changelog. Check out these docs, the "integrations-core" tab.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sarah-witt sarah-witt enabled auto-merge June 23, 2025 20:01
@sarah-witt sarah-witt disabled auto-merge June 23, 2025 20:06
@sarah-witt sarah-witt merged commit 37cce7c into DataDog:master Jun 23, 2025
26 checks passed
Kyle-Neale pushed a commit that referenced this pull request Jun 24, 2025
* Modernize bs4 interface

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>

* Modernize bs4 interface

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>

---------

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants