Skip to content

[FA] Stop relying on hardcoded value of run_path #20574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2025

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jun 24, 2025

What does this PR do?

Rely on the datadog_agent config run_path instead of the hardcoded /opt/datadog-agent

Motivation

If a user installs the agent with Remote Management enabled, the installation path of the agent is /opt/datadog-packages/datadog-agent/<version>, so the default value was not working

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (1a00621) to head (a9b26b5).
Report is 16 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
glusterfs 78.96% <45.45%> (-1.04%) ⬇️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coignetp coignetp added this pull request to the merge queue Jun 26, 2025
Merged via the queue into master with commit 50fa097 Jun 26, 2025
43 of 45 checks passed
@coignetp coignetp deleted the paul/fa-gluster-fs-exp branch June 26, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants