[ABLD-28] Bump delocate for better macOS multiarch support
#20577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working on adding support for macOS AArch64/ARM64 "native" build, I
faced that:
```py
Using existing wheel
--> cm_client-45.0.4-py3-none-any.whl
--> confluent_kafka-2.8.0-cp312-cp312-macosx_11_0_universal2.whl
Traceback (most recent call last):
[...]
NotImplementedError: This function does not support separate values per-architecture: {'x86_64': [('/usr/lib/libSystem.B.dylib', '1.0.0', '1336.61.1')], 'arm64': [('/Users/runner/builder_root/prefix/lib/librdkafka.1.dylib', '0.0.0', '0.0.0'), ('/usr/lib/libSystem.B.dylib', '1.0.0', '1336.61.1')]}
```
See:
https://github.com/DataDog/integrations-core/actions/runs/15850271495/job/44681764771?pr=20455#step:7:17535
It turns out this issue got resolved through:
- matthew-brett/delocate#230
... and shipped with `delocate` **0.13.0**:
- https://github.com/matthew-brett/delocate/releases/tag/0.13.0
- https://pypi.org/project/delocate/0.13.0/
The present change aims at taking advantage of it, which indeed seems to
work as intended:
```py
Using existing wheel
--> cm_client-45.0.4-py3-none-any.whl
--> confluent_kafka-2.8.0-cp312-cp312-macosx_11_0_universal2.whl
Repaired wheel
Libraries copied into the wheel:
/Users/runner/builder_root/prefix/lib/librdkafka.1.dylib
/Users/runner/builder_root/prefix/lib/liblmdb.so
/Users/runner/builder_root/prefix/lib/libcurl.4.dylib
/Users/runner/builder_root/prefix/lib/libssl.3.dylib
/Users/runner/builder_root/prefix/lib/libcrypto.3.dylib
/Users/runner/builder_root/prefix/lib/libz.1.3.1.dylib
```
See:
https://github.com/DataDog/integrations-core/actions/runs/15851063188/job/44684393512?pr=20455#step:7:17513
rdesgroppes
force-pushed
the
regis.desgroppes/bump-delocate-for-multiarch-support
branch
from
02c3b19 to
65d7154
Compare
rdesgroppes
changed the title
delocate for better macOS multiarch supportdelocate for better macOS multiarch support
Kyle-Neale
approved these changes
Jun 24, 2025
sarah-witt
approved these changes
Jun 24, 2025
steveny91
approved these changes
Jun 24, 2025
rdesgroppes
deleted the
regis.desgroppes/bump-delocate-for-multiarch-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump
delocateto a version that better supports Python wheels embedding multiple macOS architectures.Motivation
Working on adding support for macOS AArch64/ARM64 "native" build, I faced that:
See https://github.com/DataDog/integrations-core/actions/runs/15850271495/job/44681764771?pr=20455#step:7:17535
It turns out this issue got resolved through:
... and shipped with
delocate0.13.0:The present change aims at taking advantage of it, which indeed seems to work as intended:
See https://github.com/DataDog/integrations-core/actions/runs/15851063188/job/44684393512?pr=20455#step:7:17513
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged