Skip to content

Add new proxysql.all_backends.count metric #20582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025
Merged

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Jun 24, 2025

What does this PR do?

Adds a metric proxysql.all_backends.count to measure all backends, whether online or not

Motivation

Originally implemented in #19438 by @frivoire

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sarah-witt sarah-witt changed the title new proxysql metric Add new proxysql.all_backends.count metric. Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (0fba9da) to head (bced66f).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
proxysql 98.98% <100.00%> (+<0.01%) ⬆️
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarah-witt sarah-witt changed the title Add new proxysql.all_backends.count metric. Add new proxysql.all_backends.count metric Jun 24, 2025
@sarah-witt sarah-witt marked this pull request as ready for review June 24, 2025 21:22
@sarah-witt sarah-witt requested review from a team as code owners June 24, 2025 21:22
brett0000FF
brett0000FF previously approved these changes Jun 24, 2025
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed brett0000FF’s stale review June 25, 2025 13:16

Review from brett0000FF is dismissed. Related teams and files:

  • documentation
    • proxysql/metadata.csv
@sarah-witt sarah-witt added this pull request to the merge queue Jun 27, 2025
Merged via the queue into master with commit 75d0b02 Jun 27, 2025
42 checks passed
@sarah-witt sarah-witt deleted the sarah/proxysql-new-metric branch June 27, 2025 15:43
github-actions bot pushed a commit to phuongdnguyen/datadog-agent-integrations-core that referenced this pull request Jun 28, 2025
* add proxysql all backends metric

* update metadata and changelog

* Add backend metrics to all metrics

* add to all metrics

* Update proxysql/metadata.csv

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>

---------

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> 75d0b02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants