Skip to content

add collect_schemas config option and deprecate schemas option #20603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

Add new collect_schemas configuration to replace deprecated schemas while maintaining backward compatibility.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@lu-zhengda lu-zhengda added the qa/skip-qa Automatically skip this PR for the next QA label Jun 27, 2025
nenadnoveljic
nenadnoveljic previously approved these changes Jun 27, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nenadnoveljic’s stale review June 27, 2025 14:49

Review from nenadnoveljic is dismissed. Related teams and files:

  • database-monitoring-agent
    • mongo/assets/configuration/spec.yaml
    • mongo/datadog_checks/mongo/config_models/deprecations.py
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (34e4fd3) to head (13405c2).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 93.13% <100.00%> (+0.23%) ⬆️
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lu-zhengda lu-zhengda added this pull request to the merge queue Jun 30, 2025
Merged via the queue into master with commit dc887ed Jun 30, 2025
40 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/mongo-config branch June 30, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants