Refactor FormulaCreator args and call parse_url automatically

[abitrolly]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This PR makes all FormulaCreator params, except URL optional, to make test calls less verbose.

Calls parse_url in constructor to ensure that supplied URL is automatically parsed (as discussed in https://github.com/Homebrew/brew/pull/20025/files#r2123010882).

The change includes fix from #20115 that restores tests run on Linux.

[MikeMcQuaid]

Thanks for splitting this out. A few nits but looks good so far.

[abitrolly]

@MikeMcQuaid addressed all comments. What to do with brew typecheck failure? Should I revert types?

EDIT: Nevermind. This is ready for review.

[MikeMcQuaid]

@abitrolly Please stop pushing to this PR. I'm going to fix it.

[MikeMcQuaid]

@abitrolly Please test the latest version here. I've completed the typechecking and refactoring.

[abitrolly]

Now I see what you mean by combining parsing logic into constructor. The assignment of instance variables became more clear. Looks good.

I kind of disagree with the way test data is processed, but that's not a blocker. Just a personal preference from Go/Python side.

[MikeMcQuaid]

@abitrolly Can you clarify whether you tested this or not? Please can we move this to a conclusion? For refactoring with no functionality change this PR has wasted a lot of time and I am losing my patience with the amount of back and forth required here.

[abitrolly]

@MikeMcQuaid I've tested it with brew tests and manually run with and without new name. Works as expected.

brew create https://github.com/buildpacks/pack/archive/refs/tags/v0.37.0.tar.gz -d

[abitrolly]

The conclusion is that it is ready long ago. )

[MikeMcQuaid]

Thanks @abitrolly.