Skip to content

rubocops: add no_autobump! rubocop #20126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

botantony
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@botantony botantony force-pushed the no_autobump_rubocops branch 2 times, most recently from ce6569e to bb12593 Compare June 17, 2025 11:26
@botantony botantony force-pushed the no_autobump_rubocops branch 2 times, most recently from 931d198 to be4ebf5 Compare June 17, 2025 14:38
@botantony botantony force-pushed the no_autobump_rubocops branch 2 times, most recently from d90824d to 9a55ee2 Compare June 17, 2025 16:51
@MikeMcQuaid
Copy link
Member

@botantony Looks good, thanks!

Sorry to keep asking for changes but: can you split out the Rubocop into a separate PR from the "enable autobump" changes? This will make it much easier to selectively revert if needed.

Signed-off-by: botantony <antonsm21@gmail.com>
@botantony botantony force-pushed the no_autobump_rubocops branch from 9a55ee2 to aecdcd4 Compare June 18, 2025 14:17
@botantony botantony changed the title Rely on new autobump list and add rubocops rubocops: add no_autobump! rubocop Jun 18, 2025
@botantony
Copy link
Contributor Author

No problems 👍
#20141

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 18, 2025
Merged via the queue into Homebrew:master with commit ccb3543 Jun 18, 2025
33 checks passed
@botantony botantony deleted the no_autobump_rubocops branch June 18, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants