Skip to content

cask/installer: remove confusing zap messaging #20138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This messaging is confusing, and doesn't feel helpful.

Currently:

╰─ brew uninstall --zap foo
==> Implied `brew uninstall --cask foo`

In my mind, I take that to be "Oh, it must have wanted me to brew uninstall --cask --zap foo". zap only applies to casks, and running brew uninstall --cask --zap foo still emits the same message, so I'm not sure what this is trying to tell the user.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 18, 2025
Merged via the queue into master with commit 43a72a1 Jun 18, 2025
33 checks passed
@MikeMcQuaid MikeMcQuaid deleted the rm-zap-messaging branch June 18, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants