rubocops/caveats: only apply dynamic logic check to core. #20155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't really matter for non-API taps.
ZhongRuoyu
approved these changes
Jun 23, 2025
carlocab
approved these changes
Jun 23, 2025
|
Thanks! I ended up following similar logic to your other formula updates using a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't really matter for non-API taps.
Apologies @Bo98 that you mentioned this in #20135 and I applied it but it ended up reverted in a later version (despite me fixing the tests).
Note @ReenigneArcher that this is effectively a revert of #20135 for non-core taps. Apologies for the confusion.