-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Open
Labels
featureIs an improvement or enhancementIs an improvement or enhancementgood first issueGood for newcomersGood for newcomersplGeneric label for PyTorch Lightning packageGeneric label for PyTorch Lightning packageprogress bar: rich
Description
🚀 Feature
Currently we have the Rich Progress Bar/Summary in Lightning. However, we only enable it if the user passes the Rich Progress Bar Callback to the Trainer manually.
I see a few options, based on what we'd like to go for in the future:
- Enable the Rich Progress Bar/Model Summary if Rich is available (@ananthsub mentioned that we might need to check for Rich 10+ Add
RichModelSummary
callback #9546 (comment)) - Put the Rich Progress Bar/Summary in Bolts. This means we can only enable the Rich Progress Bar if Bolts is installed (and a version that contains the progress bar)
- Keep as is
Personally I'm a big fan of 1 as it gives users a nice new progress bar/model summary to look at, which would be nice for a new release! All the user needs to do is pip install rich -U
.
If you have other alternatives please put below! Also please let me know which options you'd like
ananthsub and rohitgr7awaelchli and tchaton
Metadata
Metadata
Assignees
Labels
featureIs an improvement or enhancementIs an improvement or enhancementgood first issueGood for newcomersGood for newcomersplGeneric label for PyTorch Lightning packageGeneric label for PyTorch Lightning packageprogress bar: rich
Activity
awaelchli commentedon Sep 17, 2021
I have the impression that the Lightning team is very pleased with the rich progress and visualizations and it would be a shame if it went unnoticed by users. Therefore I want to vote for 1 and 2 and I have no preference for either.
kaushikb11 commentedon Sep 17, 2021
Option 1 ftw! I vote for 1. Also, we should raise a warning if the installed Rich version is < 10.
And we need to ramp up our tests for
RichProgressBar
as we are planning to have it as default. Could start by getting inspired by this.rohitgr7 commentedon Sep 17, 2021
+1 for 1
rohitgr7 commentedon Sep 18, 2021
also, why not do a small poll on #general for this? let's see what users want. you can put some screenshots over there for convenience. Also rich might be a better solution to fix some issues like this one
feat: Default to RichProgressBar and RichModelSummary if rich is avai…
feat: Default to RichProgressBar and RichModelSummary if rich is avai…
feat: Default to RichProgressBar and RichModelSummary if rich is avai…
feat: Default to RichProgressBar and RichModelSummary if rich is avai…