Refactor Tephi to work with Subplots #170
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rcomer
reviewed
Nov 15, 2024
| @matplotlib.artist.allow_rasterization | ||
| def draw( | ||
| self, renderer, line=None, text=None, min_theta=None, max_theta=None | ||
| ): |
There was a problem hiding this comment.
I'm not sure that you can use allow_rasterization and also pass extra keywords to the draw method any more. C.f. SciTools/cartopy#2333.
|
In order to maintain a backlog of relevant PRs, we automatically label them as stale after 168 days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Closes #14
This PR is adapted from code written by @bjlittle 10 years ago! It allows artists access to subplots, which opens up potential to add hodographs, norman points etc.
Left to do: