-
Notifications
You must be signed in to change notification settings - Fork 186
Add /listings folder to theme package command #6002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can't seem to sign the CLA. When I click "submit" I get:
|
Thanks, @chrisberthe! I'll raise to the team about the CLA. |
@chrisberthe please try again! You should be good to go now. |
I have signed the CLA! |
@graygilmore seems like most of the failing actions are a broader CLI thing? |
91bee02
to
71f4149
Compare
Very weird! Can you try rebasing with |
Odd indeed—I had rebased off |
@chrisberthe thanks for bearing with me on this. Looks like there's one legit failure and then we'll be good to go. You can run the tests locally with |
71f4149
to
8781a1d
Compare
8781a1d
to
9b52391
Compare
Thanks @graygilmore for spotting that. Should be good now :) |
shopify theme package
command excludes/listings/
directories from output ZIP #5975WHY are these changes introduced?
Shopify introduced new requirements for the Shopify Theme Store that require themes with multiple presets to include a
/listings
directory in their theme zip submissions.WHAT is this pull request doing?
/listings/**
pattern to include the listings directory in theme packagesHow to test your changes?
/listings
folder to themeshopify theme package
in theme directory/listings
directoryMeasuring impact
How do we know this change was effective? Please choose one:
Checklist