Skip to content

Add /listings folder to theme package command #6002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

chrisberthe
Copy link
Contributor

@chrisberthe chrisberthe commented Jun 19, 2025

WHY are these changes introduced?

Shopify introduced new requirements for the Shopify Theme Store that require themes with multiple presets to include a /listings directory in their theme zip submissions.

WHAT is this pull request doing?

  • Added /listings/** pattern to include the listings directory in theme packages
  • Updated command description to document listings directory support
  • Enhanced existing test to verify listings files are included in the zip

How to test your changes?

  • Add /listings folder to theme
  • Run shopify theme package in theme directory
  • The zip will include the /listings directory

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@chrisberthe chrisberthe requested review from a team as code owners June 19, 2025 22:02
@chrisberthe
Copy link
Contributor Author

Can't seem to sign the CLA. When I click "submit" I get:

Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' https:". Either the 'unsafe-inline' keyword, a hash ('sha256-hfE+nRXuweYYzleuHJ9Z6FWVwojdcaOfmCZoctcaIfY='), or a nonce ('nonce-...') is required to enable inline execution.

@graygilmore
Copy link
Contributor

Thanks, @chrisberthe! I'll raise to the team about the CLA.

@graygilmore
Copy link
Contributor

@chrisberthe please try again! You should be good to go now.

@chrisberthe
Copy link
Contributor Author

I have signed the CLA!

@chrisberthe
Copy link
Contributor Author

@graygilmore seems like most of the failing actions are a broader CLI thing?

@chrisberthe chrisberthe force-pushed the add/listings-to-package branch from 91bee02 to 71f4149 Compare June 20, 2025 20:33
@graygilmore
Copy link
Contributor

Very weird! Can you try rebasing with main and giving it another push. If it fails after that I'll tap the core CLI folks to have a look.

@chrisberthe
Copy link
Contributor Author

Odd indeed—I had rebased off main a couple hours ago but didn't seem to fix.

@graygilmore
Copy link
Contributor

@chrisberthe thanks for bearing with me on this. Looks like there's one legit failure and then we'll be good to go. You can run the tests locally with p test.

@chrisberthe chrisberthe force-pushed the add/listings-to-package branch from 71f4149 to 8781a1d Compare June 25, 2025 14:29
@chrisberthe chrisberthe force-pushed the add/listings-to-package branch from 8781a1d to 9b52391 Compare June 25, 2025 14:30
@chrisberthe
Copy link
Contributor Author

Thanks @graygilmore for spotting that. Should be good now :)

@graygilmore graygilmore added this pull request to the merge queue Jun 25, 2025
Merged via the queue into Shopify:main with commit 5969f8c Jun 25, 2025
50 of 56 checks passed
@chrisberthe chrisberthe deleted the add/listings-to-package branch June 25, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: shopify theme package command excludes /listings/ directories from output ZIP
3 participants