New fix for hydration loop bug #9188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes infinite loop when hydrating failed queries
|
View your CI Pipeline Execution ↗ for commit 8f89575.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9188 +/- ##
===========================================
+ Coverage 45.17% 59.56% +14.38%
===========================================
Files 206 138 -68
Lines 8237 5485 -2752
Branches 1856 1472 -384
===========================================
- Hits 3721 3267 -454
+ Misses 4076 1921 -2155
+ Partials 440 297 -143 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #9157
Closes #8677 (properly this time)
The original PR had faulty logic in the test, so it only fixed the loop bug under some very specific circumstances. The test was also broken to start with, because the mock would call itself instead of the original unmocked function, very sloppy of me. 😞
The original PR checked for if the existing query was pending, but this in itself is not enough to fix the bug, so this PR also checks for if the original query is fetching. If it is, it does not hydrate the promise (again) and so breaks the loop.