-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
refactor(query-core): use "has" in Set instead of "includes" #9221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TkDodo
merged 1 commit into
TanStack:main
from
novice0840:perf(quer-core)/replaceEqualDeep
Jun 2, 2025
Merged
refactor(query-core): use "has" in Set instead of "includes" #9221
TkDodo
merged 1 commit into
TanStack:main
from
novice0840:perf(quer-core)/replaceEqualDeep
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit dd0b82d.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9221 +/- ##
===========================================
+ Coverage 45.19% 59.64% +14.44%
===========================================
Files 206 138 -68
Lines 8240 5496 -2744
Branches 1861 1477 -384
===========================================
- Hits 3724 3278 -446
+ Misses 4076 1921 -2155
+ Partials 440 297 -143 🚀 New features to boost your workflow:
|
TkDodo
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function "include" has O(n) complexity. I changed "include" to "has" in Set. So, it would be faster than original function