Skip to content

test(query-core/focusManager): use 'advanceTimersByTime' for boolean focused arg test #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

test(query-core/focusManager): use 'advanceTimersByTime' for boolean focused arg test #9317

merged 1 commit into from
Jun 27, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jun 27, 2025

advanceTimersByTimeAsync is intended for cases with asynchronous behavior, but this test runs synchronously, so it was replaced with advanceTimersByTime.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8c51a6f.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 52s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-27 14:43:48 UTC

@sukvvon sukvvon force-pushed the test/query-core-focusManager-add-advanceTimersByTime branch from 1b83509 to 8c51a6f Compare June 27, 2025 14:39
@sukvvon sukvvon changed the title test(query-core/focusManager): use advanceTimersByTime for boolean focused arg test test(query-core/focusManager): use 'advanceTimersByTime' for boolean focused arg test Jun 27, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 27, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9317

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9317

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9317

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9317

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9317

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9317

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9317

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9317

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9317

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9317

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9317

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9317

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9317

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9317

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9317

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9317

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9317

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9317

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9317

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9317

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9317

commit: 8c51a6f

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.69%. Comparing base (1078bce) to head (8c51a6f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9317       +/-   ##
===========================================
+ Coverage   45.37%   59.69%   +14.31%     
===========================================
  Files         207      136       -71     
  Lines        8277     5515     -2762     
  Branches     1862     1485      -377     
===========================================
- Hits         3756     3292      -464     
+ Misses       4080     1925     -2155     
+ Partials      441      298      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.00% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 98.15% <ø> (ø)
@tanstack/query-devtools 3.55% <ø> (ø)
@tanstack/query-persist-client-core 79.47% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.93% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.13% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.07% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit b5a9095 into TanStack:main Jun 27, 2025
7 checks passed
@sukvvon sukvvon deleted the test/query-core-focusManager-add-advanceTimersByTime branch June 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukvvon @TkDodo