test(query-core/queryClient): add 'advanceTimersByTimeAsync' and remove 'vi.waitFor' #9326

sukvvon · 2025-06-28T18:01:48Z

No description provided.

…ve 'vi.waitFor'

…sByTime-remove-waitFor

nx-cloud · 2025-06-28T18:02:29Z

View your CI Pipeline Execution ↗ for commit cf75656.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 31s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 26s	View ↗

☁️ Nx Cloud last updated this comment at 2025-06-29 07:37:37 UTC

pkg-pr-new · 2025-06-28T18:04:57Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9326

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9326

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9326

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9326

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9326

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9326

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9326

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9326

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9326

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9326

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9326

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9326

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9326

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9326

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9326

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9326

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9326

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9326

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9326

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9326

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9326

commit: cf75656

codecov · 2025-06-28T18:06:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.69%. Comparing base (33c69ec) to head (cf75656).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9326       +/-   ##
===========================================
+ Coverage   45.37%   59.69%   +14.31%     
===========================================
  Files         207      136       -71     
  Lines        8277     5515     -2762     
  Branches     1871     1485      -386     
===========================================
- Hits         3756     3292      -464     
+ Misses       4080     1925     -2155     
+ Partials      441      298      -143

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`85.00% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (ø)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`98.15% <ø> (ø)`
@tanstack/query-devtools	`3.55% <ø> (ø)`
@tanstack/query-persist-client-core	`79.47% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`95.93% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.13% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.07% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.10% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…sByTime-remove-waitFor

manudeli · 2025-06-29T07:00:51Z

packages/query-core/src/__tests__/queryClient.test.tsx

-      await vi.waitFor(() =>
-        expect(queryClient.getQueryData(key1)).toEqual(undefined),
-      )
+      await vi.advanceTimersByTimeAsync(1)


…sByTime-remove-waitFor

manudeli

Thanks 👍

…sByTime-remove-waitFor

sukvvon added 2 commits June 29, 2025 03:00

test(query-core/queryClient): add 'advanceTimersByTimeAsync' and remo…

b707ce2

…ve 'vi.waitFor'

Merge branch 'main' into test/query-core-queryClient-add-advanceTimer…

7368a7e

…sByTime-remove-waitFor

github-actions bot added the package: query-core label Jun 28, 2025

Merge branch 'main' into test/query-core-queryClient-add-advanceTimer…

13f8347

…sByTime-remove-waitFor

manudeli reviewed Jun 29, 2025

View reviewed changes

Merge branch 'main' into test/query-core-queryClient-add-advanceTimer…

8f8c667

…sByTime-remove-waitFor

manudeli approved these changes Jun 29, 2025

View reviewed changes

manudeli added 2 commits June 29, 2025 16:24

Merge branch 'main' into test/query-core-queryClient-add-advanceTimer…

a2f45e2

…sByTime-remove-waitFor

Merge branch 'main' into test/query-core-queryClient-add-advanceTimer…

cf75656

…sByTime-remove-waitFor

manudeli merged commit b16e793 into TanStack:main Jun 29, 2025
7 checks passed

sukvvon deleted the test/query-core-queryClient-add-advanceTimersByTime-remove-waitFor branch June 29, 2025 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test(query-core/queryClient): add 'advanceTimersByTimeAsync' and remove 'vi.waitFor' #9326

test(query-core/queryClient): add 'advanceTimersByTimeAsync' and remove 'vi.waitFor' #9326

Uh oh!

sukvvon commented Jun 28, 2025

Uh oh!

nx-cloud bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

manudeli Jun 29, 2025

Uh oh!

manudeli left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

test(query-core/queryClient): add 'advanceTimersByTimeAsync' and remove 'vi.waitFor' #9326

test(query-core/queryClient): add 'advanceTimersByTimeAsync' and remove 'vi.waitFor' #9326

Uh oh!

Conversation

sukvvon commented Jun 28, 2025

Uh oh!

nx-cloud bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

manudeli Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

manudeli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nx-cloud bot commented Jun 28, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 28, 2025 •

edited

Loading

codecov bot commented Jun 28, 2025 •

edited

Loading

manudeli left a comment •

edited

Loading