Memoize reused time ranges #906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pengyu-hou had a chance to look at this? |
nikhilsimha
approved these changes
Mar 12, 2025
Hi @smcnamara2-stripe I stamped it already. @hzding621 , could you take a look? |
pengyu-hou
approved these changes
Mar 12, 2025
smcnamara2-stripe
force-pushed
the
smcnamara/memoize-time-ranges
branch
from
3d21cfb to
5a5e80b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why / Goal
When calculating the ts ranges for unfilled partitions, we often do the same work repeatedly.
Internally at Stripe this has resulted in multi-hour wallclock savings for certain apps.
Test Plan
Covered by existing tests. Been running in prod at Stripe for months.
Checklist
Reviewers