Fixing assert on backfillStartDate #940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengyu-hou
requested changes
Mar 11, 2025
| groupByConf.backfillStartDate != null || overrideStartPartition != null, | ||
| s"GroupBy:${groupByConf.metaData.name} has null backfillStartDate or overrideStartPartition." + | ||
| s" This needs to be set for offline backfilling." | ||
| ) | ||
| groupByConf.setups.foreach(tableUtils.sql) | ||
| val overrideStart = overrideStartPartition.getOrElse(groupByConf.backfillStartDate) |
There was a problem hiding this comment.
So the group by backfill start date is meant for DAG and task scheduling purpose. If there is no such parameter, we should not even enter the group by backfill mode.
And the start partition override is implemented at line 694 already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable overrideStartPartition when backfillStartDate is not passed, for more details #939
Why / Goal
This will help airflow DAG to run everyday without specifying it from Feature definition
Test Plan
Checklist
Reviewers
@pengyu-hou @caiocamatta-stripe @piyush-zlai