Fix type hints for enums referring to ttypes #971
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes type hints for enum values to
int
s instead of the class type.Why / Goal
Current type hints for enum values are incorrect because of the way Thrift compiles them in Python. E.g. for
ttypes.Accuracy
:So a parameter defined as
def my_func(accuracy: ttypes.Accuracy = ttypes.Accuracy.TEMPORAL)
ends up being an incorrect assignment becauseTEMPORAL
is just an int.To improve usability with IDEs and lint tools, along the same lines as #969.
Test Plan
Checklist
Reviewers