Write daily IRs for incremental aggregation #998
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengyu-hou
reviewed
Jun 10, 2025
| @@ -176,8 +177,13 @@ object Extensions { | |||
|
|
|||
| def outputColumnName = | |||
| s"${aggregationPart.inputColumn}_$opSuffix${aggregationPart.window.suffix}${bucketSuffix}" | |||
|
|
|||
| def incOutputColumnName = | |||
| s"${aggregationPart.inputColumn}_$opSuffix${bucketSuffix}" | |||
There was a problem hiding this comment.
should we still keep the aggregationPart.window.suffix? Otherwise, how do we reconstruct the final output column?
There was a problem hiding this comment.
@pengyu-hou not sure I get it. I can not use the window.suffix right as the intermediate incremental is daily aggregation.
pengyu-hou
reviewed
Jun 10, 2025
| @@ -70,6 +70,11 @@ class RowAggregator(val inputSchema: Seq[(String, DataType)], val aggregationPar | |||
| .toArray | |||
| .zip(columnAggregators.map(_.irType)) | |||
|
|
|||
| val incSchema = aggregationParts | |||
There was a problem hiding this comment.
I am thinking that we should use a full incremental in the code and we can keep inc as the suffix for the table so the table names are not getting too long. What do you think?
Suggested change
| val incSchema = aggregationParts | |
| val incrementalSchema = aggregationParts |
added 9 commits
June 13, 2025 18:10
pengyu-hou
reviewed
Jun 20, 2025
| implicit val tableUtils = TableUtils(spark) | ||
|
|
||
| val namespace = "test_incremental_group_by" | ||
|
|
There was a problem hiding this comment.
Suggested change
| tableUtils.createDatabase(namespace) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why / Goal
Test Plan
Checklist
Reviewers