Skip to content

Fix documentation issue regarding to createTemporalTableFunction params #26645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-1.20
Choose a base branch
from

Conversation

ahmadm9212
Copy link

@ahmadm9212 ahmadm9212 commented Jun 6, 2025

What is the purpose of the change

we need to use $("field_name") instead of pure string in createTemporalTableFunction function

Brief change log

The createTemporalTableFunction function expect Experssion not string just add small fix on this part documentation.

Verifying this change

Changes happened on docs and no need to have any unit test or another thing to verifying logic.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

we need to use $("field_name") instead of pure string in `createTemporalTableFunction` function
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 6, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@@ -62,7 +62,7 @@ the versioning time attribute.
```java
TemporalTableFunction rates = tEnv
.from("currency_rates")
.createTemporalTableFunction("update_time", "currency");
.createTemporalTableFunction($("update_time"), $("currency"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include the Chinese docs change as well.

@davidradl
Copy link
Contributor

@ahmadm9212 you should title this with [hotfix] or reference the associated Jira in the title.

Also this fix is targeting 120, this should be fixed in master then back ported to version 2 and 1.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants