-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[hotfix] Remove mention of SplittableTimers in favor of InterruptibleTimers #26666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey, you need to rebase since we had an issue on master |
.getOptional(CheckpointingOptions.ENABLE_UNALIGNED_INTERRUPTIBLE_TIMERS) | ||
.ifPresent(this::enableUnalignedCheckpointsInterruptibleTimers); | ||
.getOptional(CheckpointingOptions.ENABLE_UNALIGNED_SPLITTABLE_TIMERS) | ||
.ifPresent(this::enableUnalignedCheckpointsSplitttableTimers); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: enableUnalignedCheckpointsSplitttableTimers has 3 ts here - typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha yes, I dont want to introduce another typo while trying to fix a typo
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
Outdated
Show resolved
Hide resolved
@@ -113,9 +113,8 @@ private static Stream<TestSpec<?>> specs() { | |||
.whenSetFromFile( | |||
"execution.checkpointing.unaligned.interruptible-timers.enabled", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops needs to update this too
Thanks, yes that makes sense. |
These timers were first named
SplittableTimers
but they were eventually changed toInterruptibleTimers
in the this FLIP https://cwiki.apache.org/confluence/display/FLINK/FLIP-443%3A+Interruptible+timers+firingThis PR cleans up the leftover mentions of
SplittableTimers
to prevent confusionWhat is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation