-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(stepfunctions-tasks): properly serialize CallAwsServiceCrossRegion Lambda responses #34843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n Lambda responses
b915613
to
d2ee6e5
Compare
Overall LGTM, but security guardian is failing, could you have a look on that? |
...k/custom-resource-handlers/lib/aws-stepfunctions-tasks/cross-region-aws-sdk-handler/index.ts
Show resolved
Hide resolved
@ozelalisen Security Guardian is complaining about a test that has a role with too broad permissions. The test itself was not modified, is an old test that gives too broad permissions which makes sec guardian to mark it. If we want, we can fix it as a follow up, is not related to the current fix. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…rossregions-lambda-doesnt-return-service-response-correctly
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34768
Reason for this change
The handler in cross-region-aws-sdk-handler/index.ts file was not incorrectly returning byte-array as the payload when the called service was AWS Lambda. More details in the issue itself.
Description of changes
The handler now checks the response to identify if it is a byte-array or other type of binary data and parses it correctly into a string, which is the expected format
Describe any new or updated permissions being added
NA
Description of how you validated changes
Integ test added and unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license