Skip to content

- fixed system culture dependency in PrintfTests and RatioTests by setting InvariantCulture (failed on computer with Czech default culture) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 5, 2016

  • added some sugar to DlrConsole just to see that DLR API is not implemented yet :)

- added some sugar to DlrConsole just to see that DLR API is not implemented yet :)
@dmiller
Copy link
Member

dmiller commented Aug 5, 2016

Generally, I follow Clojure's policy on contributions (because I must): http://clojure.org/community/contributing

That requires a signed Contributor's Agreement from anyone contributing code.

Also following Clojure's practice of not doing pull requests, but using JIRA for creating issues and delivering patches. http://dev.clojure.org/jira/browse/CLJCLR

For the system culture dependency, the change is simple enough that I can just do that.
The DLRConsole changes are more significant and I would not make them without following protocol.
I'm curious as to why you are interested in DLRConsole. That was not intended for general use, just a check program I wrote a long time ago to verify I had the pieces I needed for minimal DLR integration.

@ghost
Copy link
Author

ghost commented Aug 11, 2016

Thanks for feedback, I appreciate picking the "correct piece" of the commit (the DlrConsole piece was not ment to be along, it was there by mistake).

Just to mention, I am not using Clojure, Scheme or any other LISP to actually code (yet). I've just wanted to try it, because there are advantages of course. And being a .NET guy, I tend to squeeze as much under CLR as possible, to make further use in work.

Regarding the DLR stuff and why I've tried it: I've been harvesting a piece of SW to leverage IronPython and IronRuby as scripting languages, I've used that for test scripting and lightweight DevOps automation on some bigger business projects, so I've just wondered if I can add Clojure-CLR as DLR runtime without bigger effort. I've tried IronScheme before, but it used Microsoft.Dynamic and Microsoft.Scripting source code incompatible with mine. So for the time being I've decided to postpone efforts regarding Clojure-CLR or IronScheme.

@dmiller
Copy link
Member

dmiller commented Mar 31, 2018

Test changes will be in 1.9.

@dmiller dmiller closed this Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants