Skip to content

don't prepend *compiler-path* to assembly name #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mmcgill
Copy link

@mmcgill mmcgill commented Jun 20, 2013

The following console output illustrates the bug fixed in this commit:

    c:\github\VideoDump>(set CLOJURE_COMPILE_PATH=bin) & Clojure.Compile.exe program
    Compiling program to bin -- 366 milliseconds.

    c:\github\VideoDump>dir bin
     Volume in drive C has no label.
     Volume Serial Number is C201-2D30

     Directory of c:\github\VideoDump\bin

    06/20/2013  12:16 PM    <DIR>          .
    06/20/2013  12:16 PM    <DIR>          ..
    06/20/2013  11:58 AM             4,608 bin_SLASH_program.exe
    06/20/2013  11:58 PM             6,144 program.clj.dll
                   3 File(s)         15,360 bytes
                   2 Dir(s)  114,253,045,760 bytes free

GenClass.GenerateClass should not prepend the *compiler-path* to the
assembly name that is given to GenContext.CreateWithExternalAssembly;
the latter method already accounts for the *compiler-path* when
determining where to place the generated assembly.

GenClass.GenerateClass should not prepend the *compiler-path* to the
assembly name that is given to GenContext.CreateWithExternalAssembly;
the latter method already accounts for the *compiler-path* when
determining where to place the generated assembly.
@dmiller
Copy link
Member

dmiller commented Jul 23, 2013

Fixed in latest commit on master.

http://dev.clojure.org/jira/browse/CLJCLR-23

On Thu, Jun 20, 2013 at 12:28 PM, Matt McGill notifications@github.comwrote:

The following console output illustrates the bug fixed in this commit:

c:\github\VideoDump>(set CLOJURE_COMPILE_PATH=bin) & Clojure.Compile.exe program
Compiling program to bin -- 366 milliseconds.

c:\github\VideoDump>dir bin
 Volume in drive C has no label.
 Volume Serial Number is C201-2D30

 Directory of c:\github\VideoDump\bin

06/20/2013  12:16 PM    <DIR>          .
06/20/2013  12:16 PM    <DIR>          ..
06/20/2013  11:58 AM             4,608 bin_SLASH_program.exe
06/20/2013  11:58 PM             6,144 program.clj.dll
               3 File(s)         15,360 bytes
               2 Dir(s)  114,253,045,760 bytes free

GenClass.GenerateClass should not prepend the compiler-path to the
assembly name that is given to GenContext.CreateWithExternalAssembly;
the latter method already accounts for the compiler-path when

determining where to place the generated assembly.

You can merge this Pull Request by running

git pull https://github.com/mmcgill/clojure-clr FixGenClassForExes

Or view, comment on, or merge it at:

#7
Commit Summary

  • don't prepend compiler-path to assembly name

File Changes

Patch Links:

@mmcgill
Copy link
Author

mmcgill commented Jul 26, 2013

Thanks!

@mmcgill mmcgill closed this Jul 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants