Skip to content

add soci to nerdctl image convert #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025

Conversation

coderbirju
Copy link
Contributor

@coderbirju coderbirju commented May 28, 2025

This PR adds functionality to support nerdctl image convert using soci.
This follows the new soci convert feature.

cc: @Shubhranshu153 @swagatbora90 @AkihiroSuda

@coderbirju coderbirju changed the title add soci convert feature [DO NOT MERGE] add soci to nerdctl image convert [DO NOT MERGE] May 28, 2025
@coderbirju coderbirju marked this pull request as ready for review June 3, 2025 20:11
@coderbirju coderbirju force-pushed the add-soci-convert branch 3 times, most recently from 8559297 to f5b5d83 Compare July 1, 2025 17:56
@coderbirju coderbirju changed the title add soci to nerdctl image convert [DO NOT MERGE] add soci to nerdctl image convert Jul 1, 2025
@coderbirju coderbirju force-pushed the add-soci-convert branch 2 times, most recently from 65ae661 to fdb6138 Compare July 1, 2025 18:54
@Shubhranshu153 Shubhranshu153 reopened this Jul 2, 2025
@Shubhranshu153
Copy link
Contributor

@AkihiroSuda Can we add this to milestone 2.1.3 as well. Hopefully we can get it through tomorrow.

@AkihiroSuda AkihiroSuda added this to the v2.1.3 milestone Jul 2, 2025
@Shubhranshu153
Copy link
Contributor

Needs a rebase to fix existing soci tests.

@Shubhranshu153
Copy link
Contributor

Reduce the min size of the image or use larger image size to fix the test.

| 🟠 time="2025-07-01T19:09:49Z" level=info msg="Converting image from ghcr.io/stargz-containers/a |
        |         | lpine:3.13-org to docker.io/library/testimageconvert-soci-converted-image-aceae1d3:latest using  |
        |         | SOCI format"                                                                                     |
        |         | time="2025-07-01T19:09:49Z" level=info msg="soci: ztoc skipped - layer sha256:ca3cd42a7c9525f6ce |
        |         | 3d64c1a70982613a8235f0cc057ec9244052921853ef15 (application/vnd.docker.image.rootfs.diff.tar.gzi |
        |         | p) size 2811947 is less than min-layer-size 20971520"                                            |
        |         | time="2025-07-01T19:09:49Z" level=info msg="soci: soci: no ztocs created, all layers either skip |
        |         | ped or produced errors"                                                                          |
        |         | time="2025-07-01T19:09:49Z" level=fatal msg="failed to convert image to SOCI format: exit status |
        |         |  1"             

Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
@coderbirju coderbirju force-pushed the add-soci-convert branch 3 times, most recently from 46790bb to 134f401 Compare July 2, 2025 17:28
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit bae71e6 into containerd:main Jul 3, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants