feat: scala support + tree-sitter 0.21.1 bump #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzia2000
force-pushed
the
feat/scala-support
branch
2 times, most recently
from
ea6f045 to
2381881
Compare
|
Fixes #207 |
|
@kieran-ryan mind taking a look at this. |
yzia2000
force-pushed
the
feat/scala-support
branch
from
2381881 to
b216fe5
Compare
yzia2000
force-pushed
the
feat/scala-support
branch
from
b216fe5 to
75f4210
Compare
mpkorstanje
reviewed
Feb 21, 2025
| @@ -69,11 +74,19 @@ if (!fs.existsSync(treeSitterCli)) { | |||
| let command | |||
| if (process.env.CI) { | |||
| console.log(`Compiling ${module}`) | |||
| command = `node_modules/.bin/tree-sitter build-wasm ${module}` | |||
| if (module.endsWith('tree-sitter-php')) { | |||
| command = `node_modules/.bin/tree-sitter build --wasm ${module}/php` | |||
There was a problem hiding this comment.
Why does php get an exception here?
There was a problem hiding this comment.
The new version of tree-sitter-php is multi grammar it seems. It's got option of php (php + html) and php_only (just php).
|
Hi @yzia2000 I've merged some stuff which does some interim bumps to some of the packages that you may be relying on. Can you take a look and merge/rebase as appropriate. |
|
ping @yzia2000 is this something you're able to fix up so we can get it merged and cut in the v2 release? |
Will have to wait until the week after. But yeah will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Added scala support for step definitions and parameter type. Scala treesitter is most stable on 0.21.1 version of tree-sitter. Hence other tree-sitter variants ended up needing a bump too. C-sharp queries required minor fix.
⚡️ What's your motivation?
Treesitter support for scala.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.