Implement BigQuery Partition By statements using sqlglot #2722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
hsm207
changed the title
hsm207
commented
Jun 6, 2025
…-bigquery-partition-expressions-sqlglot
…ncPartition tests
…from bigquery_partition_specs
…tifier formatting
… and clause creation
hsm207
commented
Jun 18, 2025
| from typing import Any, Dict, Type, TypeVar, Union, Literal | ||
|
|
||
| # Constant to avoid magic strings | ||
| PARTITION_SPEC_TYPE_KEY = "_dlt_partition_spec_type" |
There was a problem hiding this comment.
@rudolfix if we remove the legacy ways to specify the partition expression, then we don't need this anymore.
hsm207
commented
Jun 18, 2025
| @@ -213,7 +217,7 @@ def test_create_table_with_partition_and_cluster(gcp_client: BigQueryClient) -> | |||
| sqlfluff.parse(sql, dialect="bigquery") | |||
| # clustering must be the last | |||
| assert sql.endswith("CLUSTER BY `col2`, `col5`") | |||
| assert "PARTITION BY `col10`" in sql | |||
| assert "PARTITION BY `col10`" in sql or "PARTITION BY col10" in sql | |||
There was a problem hiding this comment.
@rudolfix do you prefer to just remove col10? By default, sqlglot does not quote the column name if it is not needed e.g. names with space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Imeplement
Implenent BigQuery Partition By statements using sqlglot
Related Issues
Additional Context