-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Add disassembler support for macos #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add disassembler support for macos #2781
Conversation
You tested it? The issues on ClrMD are still open. microsoft/clrmd#1034 microsoft/clrmd#1230 |
I've not noticed issues listed above. I confirmed only And I'm only confirmed unit tests passed on CI. (Because I'm not have mac) |
@@ -37,19 +37,11 @@ public static IEnumerable<object[]> GetAllJits() | |||
{ | |||
yield return new object[] { Jit.RyuJit, Platform.X64, CoreRuntime.Core80 }; // .NET Core x64 | |||
} | |||
else if (RuntimeInformation.GetCurrentPlatform() is Platform.Arm64 && OsDetector.IsLinux()) | |||
else if (RuntimeInformation.GetCurrentPlatform() is Platform.Arm64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This changes affects windows-11-arm
tests also.
It would be helpful if someone could confirm DisassemblyDiagnoser's behaviors with an actual mac device.
|
It seems BenchmarkDotNet/src/BenchmarkDotNet/Disassemblers/DisassemblyDiagnoser.cs Lines 149 to 165 in f8390f8
Because macos (on ARM64) support running x86/x64 binary by using Rosetta2. So when specified binary has different architecture on macos. |
This PR intended to add DisassemblyDiagnoser supports for macos.
Currently DisassemblyDiagnoser is not supported on macos.
This limitation appears to be coming from the ClrMD library.
And It seems to be resolved in the latest version.