Fix TFM/Aspire version selection in templates #10009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enforces that when net10.0 is selected, only the .NET Aspire 9.4 option is available by removing all references and configuration entries for Aspire 9.3 where it no longer applies. Key changes include:
- Removal of the Aspire 9.3 choice and its related condition blocks from template.json files in multiple templates.
- Updates to localization files across various languages to reflect the removal of the 9.3 option.
- A change in the package reference version in the 9.4 xUnit test project CSProj file.
Reviewed Changes
Copilot reviewed 109 out of 109 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.ProjectTemplates/templates/aspire-xunit/9.4/Aspire.Tests.1.csproj | Updated the package reference for Aspire.Hosting.Testing to use a placeholder version. |
| *.template.config/template.json (across aspire-xunit, aspire‑starter, aspire‑servicedefaults, aspire‑nunit, aspire‑mstest) | Removed the choice for Aspire 9.3 and its corresponding condition entries. |
| .template.config/localize/templatestrings..json (all languages) | Updated localization entries to maintain consistency with the removal of the 9.3 option. |
src/Aspire.ProjectTemplates/templates/aspire-xunit/9.4/Aspire.Tests.1.csproj
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects a bunch of scenarios regarding selecting TFM and Aspire version combinations. If net10.0 is selected as TFM then Aspire 9.4 should be the only valid choice. Manually tested all combinations in VS via NPD and "Add .NET Aspire orchestration" scenarios.
Fixes #9950
Checklist