[Automated] Update dependencies #9252
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
github-actions
bot
force-pushed
the
update-dependencies
branch
2 times, most recently
from
22564f9 to
79e4ecf
Compare
github-actions
bot
force-pushed
the
update-dependencies
branch
from
79e4ecf to
c2ec063
Compare
joperezr
force-pushed
the
update-dependencies
branch
from
c2ec063 to
ed54381
Compare
joperezr
force-pushed
the
update-dependencies
branch
from
be8147a to
6f15814
Compare
github-actions
bot
force-pushed
the
update-dependencies
branch
from
6f15814 to
f1abbdb
Compare
joperezr
force-pushed
the
update-dependencies
branch
from
f1abbdb to
6f15814
Compare
github-actions
bot
force-pushed
the
update-dependencies
branch
from
00f3b6c to
2aba0c7
Compare
…eed to be mirrored
joperezr
force-pushed
the
update-dependencies
branch
from
2aba0c7 to
7cd38fc
Compare
| @@ -0,0 +1,236 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
FYI: @danmoseley @eerhardt @sebastienros @radical This was added with the help of copilot and it was useful locally to find the full set of packages and versions that need to be mirrored to dotnet-public, as I know that all of us have had to at some point calculate the full set in the past. Let me know if it is useful to check in or if we should just keep it in a gist or something instead. We could also consider having the update-dependencies workflow leverage this script so it prints exactly which packages need to be mirrored as part of the PR.
There was a problem hiding this comment.
yeah, now you can run a single file
There was a problem hiding this comment.
That is with 10.0 preview sdks though, and this repo is still in 9.0.x. I don't mind moving this to a C# file if still required (meaning also creating a project, etc.) but if so I think it'd be best to do it outside of this update in a separate PR.
…duplicates and improve error handling
…ualStudioCodeCredential from DefaultTokenCredentialProvider
| @@ -25,7 +25,6 @@ public DefaultTokenCredentialProvider(ILogger<DefaultTokenCredentialProvider> lo | |||
| "AzureCli" => new AzureCliCredential(), | |||
| "AzurePowerShell" => new AzurePowerShellCredential(), | |||
| "VisualStudio" => new VisualStudioCredential(), | |||
| "VisualStudioCode" => new VisualStudioCodeCredential(), | |||
There was a problem hiding this comment.
cc: @eerhardt @davidfowl wonder what your thoughts are around the breaking change here. I did it in this PR as the update of the Azure dependency marked this type (VisualStudioCodeCredential) as deprecated which broke our build. I've hence removed this as an option for now but of course that could be breaking in the scenario someone was using this, so let me know if you prefer me just suppress the warning until 10.
There was a problem hiding this comment.
The full error we were getting is:
/home/runner/work/aspire/aspire/src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultTokenCredentialProvider.cs(28,39): error CS0618: 'VisualStudioCodeCredential' is obsolete: 'This credential is deprecated because the VS Code Azure Account extension on which this credential relies has been deprecated. Consider using other dev-time credentials, such as VisualStudioCredential, AzureCliCredential, AzureDeveloperCliCredential, AzurePowerShellCredential. See the Azure Account extension deprecation notice here: microsoft/vscode-azure-account#964.' [/home/runner/work/aspire/aspire/src/Aspire.Hosting.Azure/Aspire.Hosting.Azure.csproj]
There was a problem hiding this comment.
Yea this is fine. We should mark it a breaking change.
There was a problem hiding this comment.
FYI: @IEvangelist as this is a breaking change.
There was a problem hiding this comment.
I looked at https://learn.microsoft.com/en-us/dotnet/aspire/azure/local-provisioning#azure-provisioning-credential-store and it looks like we removed this value in dotnet/docs-aspire#3047
joperezr
added
the
breaking-change
* Update package dependencies and add script that lists packages that need to be mirrored * Enhance package mapping logic in find-missing-packages.sh to prevent duplicates and improve error handling * Update ModelContextProtocol version to 0.2.0-preview.1 and remove VisualStudioCodeCredential from DefaultTokenCredentialProvider --------- Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
| <PackageVersion Include="Microsoft.FluentUI.AspNetCore.Components" Version="4.11.9" /> | ||
| <PackageVersion Include="Microsoft.FluentUI.AspNetCore.Components.Icons" Version="4.11.9" /> | ||
| <PackageVersion Include="Microsoft.FluentUI.AspNetCore.Components" Version="4.12.0" /> | ||
| <PackageVersion Include="Microsoft.FluentUI.AspNetCore.Components.Icons" Version="4.12.0" /> |
There was a problem hiding this comment.
Remove FluentUI from whatever automated tool is doing this.
Revert of these changes: #9987
Auto-generated update to the package dependencies. In order for this PR to be green, it will require all of the new dependencies to be mirrored to our AzDO NuGet feeds. Any updates made outside of the first itemgroup in Directory.Packages.props should be reverted as those are packages that get updated through arcade's dependency flow.