-
Notifications
You must be signed in to change notification settings - Fork 641
Remove leftover ElasticSearch references after moving ElasticSearch out of repo #9494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: radical <1472+radical@users.noreply.github.com>
…changes Co-authored-by: radical <1472+radical@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: radical <1472+radical@users.noreply.github.com>
@copilot please resolve merge conflict with main |
Merge conflict resolved in 346a721. The main branch removed the entire Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR cleans up leftover ElasticSearch references that remained in the repository after ElasticSearch components were moved out of the repo.
Changes Made
Package References Removed
Aspire.Elastic.Clients.Elasticsearch
fromtests/Shared/RepoTesting/Directory.Packages.Helix.props
Aspire.Hosting.Elasticsearch
fromtests/Shared/RepoTesting/Directory.Packages.Helix.props
Testcontainers.Elasticsearch
fromtests/Directory.Packages.props
Elastic.Clients.Elasticsearch
from rootDirectory.Packages.props
Code Updates
ElasticsearchResource
fromsrc/Shared/Model/KnownResourceTypes.cs
tests/Aspire.Hosting.Tests/ResourceExtensionsTests.cs
to use nginx containers instead of elasticsearch while maintaining the same test logic and coveragesrc/Aspire.Hosting/ApplicationModel/ResourceExtensions.cs
to use nginx instead of elasticsearchTesting
The changes are minimal and surgical, focusing only on removing the leftover ElasticSearch references while preserving all existing functionality.
Fixes #9109.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.com
/home/REDACTED/work/aspire/aspire/.dotnet/dotnet test tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --filter GetEnvironmentVariableValuesAsync or GetArgumentValuesAsync_ReturnsCorrectValuesForSpecialCases --verbosity minimal
(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.