Skip to content

[release/9.3] Fix Blob Container Connection String Format Exception #9496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 23, 2025

Backport of #9472 to release/9.3

/cc @sebastienros

Customer Impact

When an Azure Storage blob container is deployed the connection is not compatible with the injected client, making it unusable.

Testing

Tested manually on Azure, added a functional test for the emulator and unit tests for the connection string builder. We don't have automated tests on Azure.

Risk

Low.

Regression?

Yes.

@eerhardt
Copy link
Member

The build failures don't look like they are caused by you:

##[error]tests/Aspire.OpenAI.Tests/Aspire.OpenAI.Tests.csproj(0,0): error NU1101: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.Extensions.AI. No packages exist with this id in source(s): dotnet-extensions. PackageSourceMapping is enabled, the following source(s) were not considered: dotnet-eng, dotnet-libraries, dotnet-public, dotnet9, dotnet9-transport.

Is the branch currently broken? cc @joperezr

var blobClient = blobContainer.GetBlobClient("testKey");
var blobServiceClient = host.Services.GetRequiredService<BlobServiceClient>();
var blobContainerClient = host.Services.GetRequiredService<BlobContainerClient>();
await blobContainerClient.CreateIfNotExistsAsync(); // For Aspire 9.3 only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? Aspire should be creating the blob container, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably for the same reason we had to make this PR in 9.4 to fix some flaky tests. On 9.3 I would see failures without this line.

@sebastienros sebastienros added the Servicing-consider Issue for next servicing release review label May 27, 2025
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 27, 2025
@sebastienros
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr
Copy link
Member

/azp run dotnet.aspire

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr
Copy link
Member

The build failures don't look like they are caused by you:

##[error]tests/Aspire.OpenAI.Tests/Aspire.OpenAI.Tests.csproj(0,0): error NU1101: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.Extensions.AI. No packages exist with this id in source(s): dotnet-extensions. PackageSourceMapping is enabled, the following source(s) were not considered: dotnet-eng, dotnet-libraries, dotnet-public, dotnet9, dotnet9-transport.

Is the branch currently broken? cc @joperezr

It was, but it is now fixed. I've rettriggered CI.

@joperezr
Copy link
Member

Looks like re-running doesn't fetch latest changes on target branch, I'll try closing and re-opening. Otherwise we can just rebase the branch.

@joperezr joperezr closed this May 29, 2025
@joperezr joperezr reopened this May 29, 2025
@joperezr joperezr merged commit fcda82f into release/9.3 May 29, 2025
625 of 643 checks passed
@joperezr joperezr deleted the backport/pr-9472-to-release/9.3 branch May 29, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants