-
Notifications
You must be signed in to change notification settings - Fork 642
[release/9.3] Fix Blob Container Connection String Format Exception #9496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build failures don't look like they are caused by you:
Is the branch currently broken? cc @joperezr |
var blobClient = blobContainer.GetBlobClient("testKey"); | ||
var blobServiceClient = host.Services.GetRequiredService<BlobServiceClient>(); | ||
var blobContainerClient = host.Services.GetRequiredService<BlobContainerClient>(); | ||
await blobContainerClient.CreateIfNotExistsAsync(); // For Aspire 9.3 only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? Aspire should be creating the blob container, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably for the same reason we had to make this PR in 9.4 to fix some flaky tests. On 9.3 I would see failures without this line.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…72-to-release/9.3
/azp run dotnet.aspire |
Azure Pipelines successfully started running 1 pipeline(s). |
It was, but it is now fixed. I've rettriggered CI. |
Looks like re-running doesn't fetch latest changes on target branch, I'll try closing and re-opening. Otherwise we can just rebase the branch. |
Backport of #9472 to release/9.3
/cc @sebastienros
Customer Impact
When an Azure Storage blob container is deployed the connection is not compatible with the injected client, making it unusable.
Testing
Tested manually on Azure, added a functional test for the emulator and unit tests for the connection string builder. We don't have automated tests on Azure.
Risk
Low.
Regression?
Yes.