-
Notifications
You must be signed in to change notification settings - Fork 640
[release/9.3] Force SqlDatabase resource api version #9535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR backports a fix to update the API version for Azure SQL Database resources so that they support the free tier properties in release/9.3.
- Updates all resource definitions for SQL databases in Bicep templates from "2021-11-01" to "2023-08-01".
- Revises the constructor call in AzureSqlExtensions.cs to pass the new API version and includes clarifying comments about the change.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
File | Description |
---|---|
tests/Aspire.Hosting.Azure.Tests/Snapshots/*verified.bicep | Updated API version for SQL database resources; removal of extraneous characters in the description annotation. |
src/Aspire.Hosting.Azure.Sql/AzureSqlExtensions.cs | Replaced the old constructor call with one that enforces the new API version, with added comments referencing the free SKU support. |
playground//.bicep | Updated API version for SQL database resource definitions to the new version. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run dotnet.aspire |
Azure Pipelines successfully started running 1 pipeline(s). |
closing and reopening to trigger a rebase and rerun of CI. |
Backport of #9530 to release/9.3
/cc @sebastienros
Customer Impact
Azure Sql Database are supposed to use the free offer by default in 9.3. However, the default api version used doesn't support the properties that are defined in order to do that. This PR bumps the api version on the resource to enable the support
Testing
Tested manually on Azure, unit tests are verifying the updated version is applied.
Verified the warning messages were gone and the databases show as using the free tier.
Risk
Low.
Regression?
No, new default deployment in 9.3