Skip to content

[release/9.3] branding for 9.3.1 #9539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Conversation

danmoseley
Copy link
Member

No description provided.

@danmoseley danmoseley requested review from joperezr and Copilot May 28, 2025 00:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version information for the upcoming 9.3.1 branding.

  • Bumps the PatchVersion from 0 to 1.
Comments suppressed due to low confidence (1)

eng/Versions.props:8

  • Please verify if the pre-release version label 'preview.1' is intended for this release; consider updating or removing it if this is a final release.
<PreReleaseVersionLabel>preview.1</PreReleaseVersionLabel>

@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label May 28, 2025
@danmoseley danmoseley changed the title branding for 9.3.1 [release/9.3] branding for 9.3.1 May 28, 2025
@danmoseley danmoseley added area-engineering-systems infrastructure helix infra engineering repo stuff and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels May 28, 2025
@danmoseley
Copy link
Member Author

Please verify if the pre-release version label 'preview.1' is intended for this release; consider updating or removing it if this is a final release.

@joperezr I assume this is fine because 9.2.1 shipped that way.

@danmoseley danmoseley requested a review from wtgodbe May 28, 2025 00:18
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, do we know why the extensions package isn't in the feed?

@danmoseley
Copy link
Member Author

It's because release/9.3 has

    <packageSource key="dotnet-extensions">
      <package pattern="Microsoft.Extensions.AI*" />
    </packageSource>

and main doesn't. This was f76a033

@joperezr what's the correct resolution of this... take the above out of nuget.config?

@joperezr
Copy link
Member

@joperezr what's the correct resolution of this... take the above out of nuget.config?

Yeah, we should remove that, and I believe there are some other changes that we'll need to do here to get a green build. If you want me to, I'm happy to take this over and push some changes later today to fix.

@danmoseley
Copy link
Member Author

Sure go ahead

@joperezr joperezr requested review from radical and eerhardt as code owners May 29, 2025 19:13
@joperezr joperezr merged commit 8b51817 into dotnet:release/9.3 May 29, 2025
176 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants