Skip to content

Disable local auth on Azure SignalR #9891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

Disable local auth on Azure SignalR #9891

merged 2 commits into from
Jun 17, 2025

Conversation

vicancy
Copy link
Contributor

@vicancy vicancy commented Jun 16, 2025

Description

Fixes #9798

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 06:36
@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jun 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables disabling local authentication on Azure SignalR resources to address issue #9798.

  • Exposes a new DisableLocalAuth flag in the AzureSignalR resource builder.
  • Updates SignalR Bicep modules to set disableLocalAuth: true.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Aspire.Hosting.Azure.SignalR/AzureSignalRExtensions.cs Adds DisableLocalAuth = true property to the resource
playground/signalr/SignalR.AppHost/signalrServerless.module.bicep Sets disableLocalAuth: true in serverless module
playground/signalr/SignalR.AppHost/signalrDefault.module.bicep Sets disableLocalAuth: true in default module
Comments suppressed due to low confidence (3)

src/Aspire.Hosting.Azure.SignalR/AzureSignalRExtensions.cs:87

  • No unit tests cover the new DisableLocalAuth flag; add tests to verify it is correctly applied and serialized by the resource builder.
DisableLocalAuth = true,

playground/signalr/SignalR.AppHost/signalrServerless.module.bicep:13

  • Add integration or scenario tests for the Bicep module to validate that disableLocalAuth is set as expected in the generated deployment template.
disableLocalAuth: true

playground/signalr/SignalR.AppHost/signalrDefault.module.bicep:13

  • Add integration or scenario tests for the Bicep module to validate that disableLocalAuth is set as expected in the generated deployment template.
disableLocalAuth: true

@davidfowl davidfowl merged commit 54395b2 into dotnet:main Jun 17, 2025
252 checks passed
@vicancy vicancy deleted the ff2 branch June 18, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Local Auth on Azure SignalR
2 participants