Skip to content

Update xunit.v3 to 3.0.0-pre.25 #9894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Update xunit.v3 to 3.0.0-pre.25 #9894

merged 2 commits into from
Jun 20, 2025

Conversation

Youssef1313
Copy link
Member

Description

See #9876 (comment).

@mitchdenny Can you verify if this resolves the "go to test" issues? It's then up to you to wait for a stable version, or merging the prerelease. Also note that this should bring a bit of performance benefit for discovery.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 09:28
@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jun 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the xUnit dependency version in Versions.props from 2.0.3 to 3.0.0-pre.25 to address "go to test" issues and improve performance.

  • Upgrades xUnit from a stable to a prerelease version.
  • Aims to resolve test discovery performance and behavior issues.
Comments suppressed due to low confidence (1)

eng/Versions.props:15

  • Ensure that all test projects and build configurations are validated against this prerelease version to avoid potential discrepancies with xUnit v3 APIs.
<XunitV3Version>3.0.0-pre.25</XunitV3Version>

@Youssef1313
Copy link
Member Author

#9895 needs to be merged first.

@mitchdenny mitchdenny mentioned this pull request Jun 17, 2025
16 tasks
@danmoseley
Copy link
Member


CSC : error CS1705: Assembly 'xunit.v3.runner.inproc.console' with identity 'xunit.v3.runner.inproc.console, Version=3.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c' uses 'Microsoft.Testing.Platform, Version=1.7.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version than referenced assembly 'Microsoft.Testing.Platform' with identity 'Microsoft.Testing.Platform, Version=1.6.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [/home/runner/work/aspire/aspire/tests/Aspire.EndToEnd.Tests/Aspire.EndToEnd.Tests.csproj]

@danmoseley danmoseley closed this Jun 19, 2025
@danmoseley danmoseley reopened this Jun 19, 2025
@mitchdenny
Copy link
Member

@davidfowl @captainsafia @joperezr @radical I think we should consider taking this change in the interests for productivity improvements. Combined with the updated MTP library that just merged into main, this prerelease package fixes the Go to Test experience in VSCode which I know that @davidfowl, @captainsafia and I have been struggling with.

I think its safe to take the dependency because I don't think it'll impact any of the packages/templates that we ship.

@mitchdenny mitchdenny merged commit ee6ebbb into main Jun 20, 2025
261 of 266 checks passed
@mitchdenny mitchdenny deleted the dev/ygerges/xunitv3-update branch June 20, 2025 02:34
captainsafia pushed a commit that referenced this pull request Jun 20, 2025
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants