Skip to content

rename InteractionService to ConsoleInteractionService #9908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

adamint
Copy link
Member

@adamint adamint commented Jun 17, 2025

this is for disambiguation when ExtensionInteractionService is added

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 04:56
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Renames the generic InteractionService to ConsoleInteractionService to avoid ambiguity when adding an ExtensionInteractionService.

  • Renamed the core service class and its references in DI registration.
  • Updated tests to use TestConsoleInteractionService and renamed test classes accordingly.
  • Adjusted factory and instantiation points throughout tests and Program.cs.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Aspire.Cli.Tests/Utils/CliTestHelper.cs Switched factory from InteractionService to ConsoleInteractionService.
tests/Aspire.Cli.Tests/TestServices/TestConsoleInteractionService.cs Renamed test class to TestConsoleInteractionService.
tests/Aspire.Cli.Tests/Projects/ProjectLocatorTests.cs Updated all TestInteractionService instantiations to TestConsoleInteractionService.
tests/Aspire.Cli.Tests/Interaction/ConsoleInteractionServiceTests.cs Renamed test class and instantiation to ConsoleInteractionService.
tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs Updated TestInteractionService to TestConsoleInteractionService.
tests/Aspire.Cli.Tests/Commands/AddCommandTests.cs Updated TestInteractionService to TestConsoleInteractionService.
src/Aspire.Cli/Program.cs Changed DI registration from InteractionService to ConsoleInteractionService.
src/Aspire.Cli/Interaction/ConsoleInteractionService.cs Renamed class from InteractionService to ConsoleInteractionService.

Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good disambiguation for future changes coming for extension integration.

@adamint adamint merged commit 1522934 into dotnet:main Jun 17, 2025
497 of 499 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants