Skip to content

Fix dashboard URL display in Aspire CLI after localization changes. #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

mitchdenny
Copy link
Member

Quick fix to an issue where the dashboard URL wasn't rendering correctly (string interpolation issue).

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 05:42
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Spectre.Console markup so that the dashboard URL renders correctly in the Aspire CLI after recent localization changes.

  • Removes the incorrect $[link=…] interpolation syntax.
  • Updates the direct link markup to use [link=…] inside the interpolated string.

@mitchdenny mitchdenny enabled auto-merge (squash) June 17, 2025 05:58
@mitchdenny mitchdenny merged commit 16dbd2f into main Jun 17, 2025
253 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/run-fix branch June 17, 2025 06:02
@davidfowl
Copy link
Member

We really need tests. We can't break basic behavior like this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants