Quarantine flaky test TracingEnablesTheRightActivitySource_Keyed #9918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
radical
June 17, 2025 17:09
There was a problem hiding this comment.
Pull Request Overview
This PR quarantines a flaky test to prevent it from causing false negatives in regular CI test runs while still allowing it to be executed in the outerloop workflow.
- Added a using directive for Aspire.TestUtilities to enable the QuarantinedTestAttribute.
- Applied the [QuarantinedTest] attribute to the key-based test method to mark it as quarantined.
joperezr
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR quarantines the flaky test
Aspire.Azure.AI.OpenAI.Tests.ConformanceTests.TracingEnablesTheRightActivitySource_Keyedby adding the[QuarantinedTest]attribute.Changes Made
using Aspire.TestUtilities;import to enable use of theQuarantinedTestAttribute[QuarantinedTest("https://github.com/dotnet/aspire/issues/9916")]attribute to theTracingEnablesTheRightActivitySource_Keyedtest methodImpact
The flaky test is now excluded from regular CI test runs to prevent false negatives, but will continue to run in the outerloop workflow for monitoring. This follows the established pattern for handling flaky tests in the codebase.
Verification
quarantined=truetraitFixes #9917.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.