Skip to content

Main #9920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Main #9920

merged 1 commit into from
Jun 19, 2025

Conversation

joperezr
Copy link
Member

Description

Removing cgmanifest.json file since we are now building the templates and test projects from it in our official builds and we are running Component Governance against those, so we no longer need a cgmanifest.json.

cc: @radical, @eerhardt @sebastienros

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 18:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the obsolete cgmanifest.json file as it is no longer used for component governance in our official builds and updates the associated comment in Versions.props.

  • Removed cgmanifest.json from the project templates directory.
  • Updated the Versions.props file to remove outdated comments referencing cgmanifest.json.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Aspire.ProjectTemplates/cgmanifest.json File removed as it is no longer required.
eng/Versions.props Removed comment referencing cgmanifest.json.

@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jun 17, 2025
@joperezr joperezr requested review from radical and sebastienros June 17, 2025 18:56
@radical
Copy link
Member

radical commented Jun 17, 2025

@danmoseley danmoseley merged commit 8385704 into main Jun 19, 2025
253 checks passed
@danmoseley danmoseley deleted the RemoveCGManifest branch June 19, 2025 20:33
@joperezr
Copy link
Member Author

lol, just noticed the PR title which absolutely makes no sense. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants