Skip to content

Add k8s tooling. #9925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Add k8s tooling. #9925

merged 1 commit into from
Jun 18, 2025

Conversation

mitchdenny
Copy link
Member

This PR adds Kubernetes tooling to our repo which will make dogfooding kubernetes scenarios in devcontainers/codespaces easier:

image

If you want to spin up a Kubernetes cluster in your devcontainer now you can just do minikube start. Works in Codespaces too.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 18, 2025
@mitchdenny mitchdenny self-assigned this Jun 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Kubernetes tooling support to the devcontainer configuration for improved dogfooding of Kubernetes scenarios in Codespaces and devcontainers.

  • Added the "kubectl-helm-minikube" feature with settings to use the latest versions for kubectl, helm, and minikube.
  • Updated extension recommendations by adding the VS Code Kubernetes Tools extension.
Comments suppressed due to low confidence (1)

.devcontainer/devcontainer.json:48

  • Ensure that the extension identifier 'ms-kubernetes-tools.vscode-kubernetes-tools' is correctly configured and supported in your development environment.
				"ms-kubernetes-tools.vscode-kubernetes-tools"

Comment on lines +19 to +21
"version": "latest",
"helm": "latest",
"minikube": "latest"
Copy link
Preview

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'latest' for version, helm, and minikube may lead to unexpected breaking changes. Consider pinning explicit versions to ensure consistent development environments.

Suggested change
"version": "latest",
"helm": "latest",
"minikube": "latest"
"version": "1.27.4",
"helm": "3.12.3",
"minikube": "1.30.1"

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem like good guidance unless we want to stay on the bleeding edge in order to be able to validate things.

@mitchdenny
Copy link
Member Author

Related:
dotnet/aspire-devcontainer-nightly#3

@mitchdenny mitchdenny requested a review from davidfowl June 18, 2025 03:19
@mitchdenny mitchdenny removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 18, 2025
@mitchdenny mitchdenny merged commit 2603692 into main Jun 18, 2025
253 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/k8s-tooling branch June 18, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants