[Blazor] Pass environment to runtime config only when defined #62418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
area-blazor
javiercn
reviewed
Jun 20, 2025
src/Components/test/testassets/BasicTestApp/BasicTestApp.csproj
Outdated
Show resolved
Hide resolved
javiercn
approved these changes
Jun 20, 2025
javiercn
approved these changes
Jun 20, 2025
|
/ba-g Failures are not related |
|
/backport to release/10.0-preview6 |
|
Started backporting to release/10.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/15781007622 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a regression from merging boot config into dotnet.js. After that change, boot config is always loaded "immediately" & options passed from blazor are applied after it. In general, this is good as it allows to override default build values with those provided by user. We just need to be careful about default (null or undefined) values.
We have an E2E test, but on CI it fallbacks to
Productionvalue, which is also a default value. I'm changing the test to have a value ofStagingwhen running on CI andDevelopmentwhen running in debug.Fixes #62362