[RGen] Use the global alias with the Libraries class. #22623

mandel-macaque · 2025-04-15T16:31:56Z

As with others, avoid namespace collisions.

This way we reduce the possible collisions with the user namespaces.

As with others, avoid namespace collisions.

…bal-libraries

StephaneDelcroix

global everything

StephaneDelcroix · 2025-04-17T07:58:36Z

tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/ExpectedCIImage.cs

@@ -121,7 +121,7 @@ public static partial Foundation.NSString DidProcessEditingNotification
 		get
 		{
 			if (_DidProcessEditingNotification is null)
-				_DidProcessEditingNotification = global::ObjCRuntime.Dlfcn.GetStringConstant (Libraries.TestNamespace.Handle, "kCIFormatLA8")!;
+				_DidProcessEditingNotification = global::ObjCRuntime.Dlfcn.GetStringConstant (global::ObjCRuntime.Libraries.TestNamespace.Handle, "kCIFormatLA8")!;


vs-mobiletools-engineering-service2 · 2025-05-01T21:30:05Z

✅ [PR Build #401ec77] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T21:57:09Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T22:02:38Z

✅ [CI Build #401ec77] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T22:33:36Z

✅ [CI Build #401ec77] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T22:44:30Z

💻 [CI Build #401ec77] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T22:46:41Z

💻 [CI Build #401ec77] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T22:46:57Z

💻 [CI Build #401ec77] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T22:48:30Z

💻 [CI Build #401ec77] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-02T00:41:48Z

🚀 [CI Build #401ec77] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 401ec774e0b7089295e573f305fb9e7d54a73591 [PR build]

mandel-macaque and others added 4 commits April 14, 2025 16:54

[RGen] Uset the global alias for NSValue and NSNumber.

ede32a0

This way we reduce the possible collisions with the user namespaces.

Auto-format source code

ea7c1c9

Merge branch 'main' into dev/mandel/global-nsvalue-nsnumber

f969ae2

[RGen] Use the global alias with the Libraries class.

d3f770b

As with others, avoid namespace collisions.

dalexsoto approved these changes Apr 15, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque added 2 commits April 16, 2025 07:53

Merge branch 'main' into dev/mandel/global-nsvalue-nsnumber

c5dbe1d

Merge branch 'dev/mandel/global-nsvalue-nsnumber' into dev/mandel/glo…

68c3f10

…bal-libraries

This comment has been minimized.

Sign in to view

StephaneDelcroix approved these changes Apr 17, 2025

View reviewed changes

Base automatically changed from dev/mandel/global-nsvalue-nsnumber to main April 17, 2025 13:12

Merge branch 'main' into dev/mandel/global-libraries

1146da0

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Apr 21, 2025

View reviewed changes

Merge branch 'main' into dev/mandel/global-libraries

401ec77

mandel-macaque merged commit b138f49 into main May 2, 2025
44 checks passed

mandel-macaque deleted the dev/mandel/global-libraries branch May 2, 2025 20:13

[RGen] Use the global alias with the Libraries class. #22623

[RGen] Use the global alias with the Libraries class. #22623

Uh oh!

Conversation

mandel-macaque commented Apr 15, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

StephaneDelcroix left a comment

Choose a reason for hiding this comment

Uh oh!

StephaneDelcroix Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 1, 2025

✅ [PR Build #401ec77] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 1, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 1, 2025

✅ [CI Build #401ec77] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 1, 2025

✅ [CI Build #401ec77] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 1, 2025

💻 [CI Build #401ec77] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 1, 2025

💻 [CI Build #401ec77] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 1, 2025

💻 [CI Build #401ec77] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 1, 2025

💻 [CI Build #401ec77] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 2, 2025

🚀 [CI Build #401ec77] Test results 🚀

Test results

Tests counts

Uh oh!