[build][net10.0] Use SharedFramework.Sdk to create workload packs #22660

pjcollins · 2025-04-23T20:16:11Z

Additional context: dotnet/android@dc08972

The workload packaging logic has been updated to use more of the
Microsoft.DotNet.SharedFramework.Sdk MSBuild SDK included in the
dotnet/arcade repo.

This SDK allows us to easily exclude the symbols files that we've
been shipping directly in all of our workload packs, and instead move
them into *.symbols.nupkg packages that can be archived and
uploaded to a symbol server separately.

Symbols can be filtered out of regular nupkg files by setting the
%(FilesToPackage.IsSymbolFile) metadata to "true".

While we now have an option to easily exclude symbols from a given pack,
symbols will continue to be shipped in runtime and SDK packs to support
improved debugging and non-VS build scenarios.

The targets updates in dotnet/package/common.csproj lean heavily on
the targets and items defined in sharedfx.targets.

The workload packaging logic has been updated to use more of the [Microsoft.DotNet.SharedFramework.Sdk][0] MSBuild SDK included in the dotnet/arcade repo. This SDK allows us to easily exclude the symbols files that we've been shipping directly in all of our workload packs, and instead move them into `*.symbols.nupkg` packages that can be archived and uploaded to a symbol server separately. The targets updates in `dotnet/package/common.csproj` lean heavily on the targets and items defined in [sharedfx.targets][1]. [0]: https://github.com/dotnet/arcade/tree/21f46f494265f11e124c47ee868fac199768a35b/src/Microsoft.DotNet.SharedFramework.Sdk [1]: https://github.com/dotnet/arcade/blob/2b1931c05dd6ceb89120131a8b39eaa81735179a/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L398-L429

dotnet/package/common.csproj

pjcollins · 2025-04-23T23:47:51Z

@rolfbjarne I'm working on some packaging changes here to separate out symbols from the workload sdk packs, tagging you in for some early review whenever you have the chance.

One thing I was unsure about is how

https://github.com/dotnet/macios/blob/main/tests/test-libraries/nugets/FrameworksInRuntimesNativeDirectory/FrameworksInRuntimesNativeDirectory.csproj#L32
and
https://github.com/dotnet/macios/blob/main/tests/test-libraries/nugets/XCFrameworkWithStaticLibraryInRuntimesNativeDirectory/XCFrameworkWithStaticLibraryInRuntimesNativeDirectory.csproj#L32

are used and if they need to be generating these FrameworkList and RuntimeList files? I can update them to do so in this newer way if needed, or maybe we can remove that bit from the projects?

pjcollins · 2025-04-24T19:49:20Z

Testing end to end in VS with the following, expecting the VS build to fail but symbol check should be green:
VS insertion pipeline update: https://devdiv.visualstudio.com/DevDiv/_git/Xamarin.sdk-insertions/pullrequest/631379
VS insertion run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11469996&view=results
VS PR: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/631392

vs-mobiletools-engineering-service2 · 2025-05-01T07:11:31Z

✅ [CI Build #2b7e28d] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T07:12:24Z

✅ [CI Build #2b7e28d] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T07:47:57Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T08:17:20Z

✅ [CI Build #2b7e28d] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T08:28:27Z

💻 [CI Build #2b7e28d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T08:30:43Z

💻 [CI Build #2b7e28d] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T08:31:22Z

💻 [CI Build #2b7e28d] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-01T08:31:59Z

💻 [CI Build #2b7e28d] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 2b7e28db532f6217e2f788cb36e920e95d4f2a20 [PR build]