[release/9.0.1xx][xma] Added targets and tasks to copy modified dll and pdb files back to Windows #22680

mauroa · 2025-04-25T14:06:13Z

With the new ICorDebug engine for MAUI, we need the debugger to always load the assemblies from Windows. Given that some dll and pdb files changes as part of the remote build, we need a mechanism to copy those modified files back to the Windows OutputPath, so the debugger can always load the right files. Otherwise, the debugger will try to load files that are not the same that are in the running app, so no symbols will be loaded. This also improves the debugger performance by ensuring the files are not loaded remotely but locally

…ty outputs When a zip runs remotely, we assume that the input files are already in the remote side We also expect the resulting zip file to be copied back to the local side as part of the task execution, so we don't want empty output files created Also fixed the CopyAppBundleFromMac target as consequence

github-actions · 2025-04-28T14:52:21Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

… to Windows With the new ICorDebug engine for MAUI, we need the debugger to always load the assemblies from Windows. Given that some dll and pdb files changes as part of the remote build, we need a mechanism to copy those modified files back to the Windows OutputPath, so the debugger can always load the right files. Otherwise, the debugger will try to load files that are not the same that are in the running app, so no symbols will be loaded. This also improves the debugger performance by ensuring the files are not loaded remotely but locally

… files update logic

github-actions · 2025-04-28T14:57:10Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-04-28T15:28:02Z

✅ [PR Build #833a842] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 833a8423454fd0525589bdd7a6add6496a4528f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T15:31:24Z

✅ [CI Build #05ee876] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 05ee876b1a1286ff14f07e49e6947b2630681782 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T15:50:32Z

✅ [CI Build #05ee876] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 05ee876b1a1286ff14f07e49e6947b2630681782 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:01:40Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 833a8423454fd0525589bdd7a6add6496a4528f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:06:26Z

💻 [CI Build #05ee876] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 05ee876b1a1286ff14f07e49e6947b2630681782 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:10:19Z

💻 [CI Build #05ee876] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 05ee876b1a1286ff14f07e49e6947b2630681782 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:11:49Z

💻 [CI Build #05ee876] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 05ee876b1a1286ff14f07e49e6947b2630681782 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:13:16Z

💻 [CI Build #05ee876] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 05ee876b1a1286ff14f07e49e6947b2630681782 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T18:50:35Z

🚀 [CI Build #05ee876] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 05ee876b1a1286ff14f07e49e6947b2630681782 [PR build]

mauroa added the not-notes-worthy label Apr 25, 2025

mauroa self-assigned this Apr 25, 2025

mauroa requested review from emaf and rolfbjarne as code owners April 25, 2025 14:06

mauroa added the do-not-merge label Apr 25, 2025

mauroa force-pushed the dev/maagno/net9 branch from 76db81e to 10fdc65 Compare April 25, 2025 14:10

This comment has been minimized.

Sign in to view

mauroa force-pushed the dev/maagno/net9 branch from 10fdc65 to 2e2067e Compare April 25, 2025 15:25

This comment has been minimized.

Sign in to view

mauroa force-pushed the dev/maagno/net9 branch from 2e2067e to ee16ef5 Compare April 25, 2025 16:45

mauroa removed the do-not-merge label Apr 25, 2025

mauroa changed the title ~~[net9] Test PR~~ [release/9.0.1xx][xma] Added targets and tasks to copy modified dll and pdb files back to Windows Apr 25, 2025

This comment has been minimized.

Sign in to view

mauroa force-pushed the dev/maagno/net9 branch from 7277160 to 8b7ed9a Compare April 28, 2025 14:48

mauroa added 2 commits April 28, 2025 10:52

[xma][test] Augment RemoteTest to include validations over the output…

833a842

… files update logic

mauroa force-pushed the dev/maagno/net9 branch from f7a697f to 833a842 Compare April 28, 2025 14:52

Auto-format source code

05ee876

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Apr 29, 2025

View reviewed changes

rolfbjarne merged commit 7df1b7f into release/9.0.1xx Apr 29, 2025
43 checks passed

rolfbjarne deleted the dev/maagno/net9 branch April 29, 2025 08:41

[release/9.0.1xx][xma] Added targets and tasks to copy modified dll and pdb files back to Windows #22680

[release/9.0.1xx][xma] Added targets and tasks to copy modified dll and pdb files back to Windows #22680

Uh oh!

Conversation

mauroa commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 28, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

github-actions bot commented Apr 28, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ [PR Build #833a842] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ [CI Build #05ee876] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ [CI Build #05ee876] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #05ee876] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #05ee876] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #05ee876] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #05ee876] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 28, 2025

🚀 [CI Build #05ee876] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Uh oh!

mauroa commented Apr 25, 2025 •

edited

Loading