[msbuild] Enable design-time builds for binding projects when bundling original resources. Fixes #10148. #22985
Conversation
…g original resources. Fixes #10148. Traditionally we've disabled building projects when doing design-time builds (in an IDE), because such builds have to be quick, but building binding projects required a remote connection to a Mac when building from Windows. However, we recently completed support for building binding projects fully on Windows, with one caveat: the option to bundle original resources in the binding assembly has to be enabled (off by default in .NET 9, on by default in .NET 10+), because otherwise the remote mac connection is still needed. So here we enable design-time builds, as long as the project is bundling original resources, since the entire binding project will be built on Windows. Fixes #10148.
✅ [CI Build #d897efa] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #d897efa] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #d897efa] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #d897efa] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #d897efa] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #d897efa] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #d897efa] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #d897efa] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Traditionally we've disabled building projects when doing design-time builds
(in an IDE), because such builds have to be quick, but building binding
projects required a remote connection to a Mac when building from Windows.
However, we recently completed support for building binding projects fully on
Windows, with one caveat: the option to bundle original resources in the
binding assembly has to be enabled (off by default in .NET 9, on by default in
.NET 10+), because otherwise the remote mac connection is still needed.
So here we enable design-time builds, as long as the project is bundling
original resources, since the entire binding project will be built on Windows.
Fixes #10148.