[Rgen] Fix typo in NSString.CreateNative and make it global. #23033
Conversation
There was a typo in the class name NFString and it was not using global. 1. Fix typo. 2. Use the TypeDeclaration object from the KnwonObjects.
| @@ -127,7 +127,7 @@ public void MyMethod (Callback cb) {} | |||
|
|
|||
| yield return [ | |||
| nullableSystemStringResult, | |||
| "NFString.CreateNative (auxVariable, true)" | |||
| $"{Global ("Foundation.NSString")}.CreateNative (auxVariable, true)" | |||
There was a problem hiding this comment.
| $"{Global ("Foundation.NSString")}.CreateNative (auxVariable, true)" | |
| $"{Global ("CoreFoundation.CFString")}.CreateNative (auxVariable, true)" |
?
There was a problem hiding this comment.
not what we are looking for, we want NSString.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #5db87ad] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #5db87ad] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #5db87ad] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #5db87ad] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #5db87ad] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #5db87ad] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #5db87ad] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #5db87ad] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 0 tests failed, 108 tests passed. Failures❌ monotouch tests (macOS)🔥 Failed catastrophically on VSTS: test results - monotouch_macos (no summary found). Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Failing tests are unrelated to code changes. |
There was a typo in the class name NFString and it was not using global.