Fix FilterStaticFrameworks task to support custom framework binary names #23045

Copilot · 2025-06-13T18:10:16Z

The FilterStaticFrameworks MSBuild task was hardcoded to assume framework executables are always located at Framework.framework/Framework, but some frameworks (like FFmpeg's libavcodec) use custom executable paths specified in their Info.plist via the CFBundleExecutable property.

This caused build failures with frameworks that use custom binary names:

error MT158: The file '/path/to/libavcodec.framework/libavcodec' does not exist.

The actual executable was at libavcodec.framework/libavcodec.dylib as specified in the framework's Info.plist CFBundleExecutable property.

Solution

Added a GetFrameworkExecutablePath helper method that:

Reads Info.plist: Checks for CFBundleExecutable property in framework's Info.plist
Uses custom path: Returns the path specified by CFBundleExecutable when present
Falls back gracefully: Uses default behavior for standard frameworks or when Info.plist is missing/corrupt
Maintains compatibility: All existing frameworks continue to work unchanged

Example

Before (fails):

libavcodec.framework/
├── Info.plist  # CFBundleExecutable = "libavcodec.dylib"
└── libavcodec.dylib

Task looks for: libavcodec.framework/libavcodec ❌

After (works):
Task reads Info.plist and looks for: libavcodec.framework/libavcodec.dylib ✅

Testing

Added comprehensive tests covering:

✅ Custom CFBundleExecutable scenarios (reproduces the original issue)
✅ Standard frameworks without Info.plist (backward compatibility)
✅ Non-framework paths (edge case handling)
✅ Error handling for malformed/missing Info.plist files

Fixes #23039.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

mandel-macaque · 2025-06-13T18:32:46Z

msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworks.cs

+				try {
+					var plist = PDictionary.FromFile (infoPlistPath);
+					var bundleExecutable = plist?.GetCFBundleExecutable ();
+					if (!string.IsNullOrEmpty (bundleExecutable)) {
+						return Path.Combine (frameworkPath, bundleExecutable);
+					}
+				} catch {
+					// If reading the plist fails, fall back to the default behavior
+				}


FromFile does not raise any exception, what exception are you trying to catch? This can me cleaner with a if statement no need for the try/catch.

You're right! I've simplified the code by removing the try-catch and using explicit null checking instead. Since GetFrameworkExecutablePath is called within a larger try-catch block that handles framework validation errors appropriately, any exceptions from PDictionary.FromFile will be caught and logged with proper error messages. The refactored code is cleaner and follows the patterns used elsewhere in the codebase. Fixed in d3f208c.

mandel-macaque · 2025-06-13T18:33:42Z

msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworks.cs

@@ -20,6 +20,29 @@ public class FilterStaticFrameworks : XamarinTask, ITaskCallback {
 		[Output]
 		public ITaskItem []? FrameworkToPublish { get; set; }

+		static string GetFrameworkExecutablePath (string frameworkPath)
+		{
+			if (!frameworkPath.EndsWith (".framework", StringComparison.OrdinalIgnoreCase) || !Directory.Exists (frameworkPath))


Simplify the || to use an and so that it can be short circuit.

Simplified the logical condition to use && with short-circuiting instead of ||. The change is logically equivalent but more efficient - if the path doesn't end with ".framework", we skip the Directory.Exists check entirely. Fixed in 0b203a4.

Co-authored-by: mandel-macaque <2190086+mandel-macaque@users.noreply.github.com>

Copilot · 2025-06-13T18:50:43Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: cb9e1c42-de13-48b7-b6df-6c5a01d20da4

Sorry for the inconvenience!

Copilot · 2025-06-13T18:51:03Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17f50e8e-5c07-48bd-b0a6-bd3ed9a7a89e

Sorry for the inconvenience!

Copilot · 2025-06-13T19:02:02Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 4be25d47-1581-484e-82e7-970da6b92d8e

Sorry for the inconvenience!

Copilot · 2025-06-13T19:17:11Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: dcf50cd4-9439-4ec9-992b-43610425540e

Sorry for the inconvenience!

Copilot · 2025-06-13T19:17:29Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 6c8ca4e4-da9c-4123-b939-726c033e967b

Sorry for the inconvenience!

Copilot · 2025-06-13T19:18:50Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 4c5bad3c-8c72-4003-b1a0-b90e4818cd77

Sorry for the inconvenience!

Copilot · 2025-06-13T19:44:22Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 460b4f88-22a1-4115-9f90-a2f89adb4a54

Sorry for the inconvenience!

Copilot · 2025-06-13T19:46:47Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: fd7cd250-084d-48ff-b855-5c4b90e3eecb

Sorry for the inconvenience!

Copilot · 2025-06-13T19:48:48Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 20fb05be-412f-4678-b1ce-14fde9bfc0da

Sorry for the inconvenience!

Copilot · 2025-06-13T19:50:19Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: f4043b59-8586-488d-8edb-a67a5cc2d311

Sorry for the inconvenience!

Copilot · 2025-06-13T19:50:50Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c5bd27fb-07c5-479a-9d25-57abb0451e66

Sorry for the inconvenience!

Copilot · 2025-06-13T19:56:12Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 1fdfb70b-e78c-4550-8e22-a07f664c2376

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-13T19:59:19Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0b203a42f74807738bb65675bbc419420a7cd5a2 [PR build]

Copilot · 2025-06-13T19:59:22Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 8a7bd78b-a4c6-4960-82ae-a44041e0a2d7

Sorry for the inconvenience!

Copilot · 2025-06-13T20:01:36Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: d7a61e47-3cb9-43c2-a8a3-917a72ddbd8a

Sorry for the inconvenience!

Copilot · 2025-06-13T20:05:36Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 7bc843ce-ea16-4926-a626-fac97d95ac24

Sorry for the inconvenience!

Copilot · 2025-06-13T20:06:21Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: bd743717-bee7-4dac-9a99-fe7caca2fd80

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-13T20:06:42Z

💻 [CI Build #d3f208c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: d3f208c01f8dadc9ddc93fbd67c73e1861cca3ab [PR build]

Copilot · 2025-06-13T20:06:46Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 17c4d967-90a2-48a6-a4e9-cdc4f67fe4fe

Sorry for the inconvenience!

TomEdwardsEnscape · 2025-06-13T20:12:16Z

This narrowly fixes the problem in the specific MSBuild Task I reported, but are there other places in the toolchain making the same assumption? An integration test which builds a project with a reference to a framework with a non-default binary name is needed.

vs-mobiletools-engineering-service2 · 2025-06-13T20:18:26Z

✅ [CI Build #0b203a4] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0b203a42f74807738bb65675bbc419420a7cd5a2 [PR build]

Copilot · 2025-06-13T20:18:30Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: e65e38b0-718b-4f87-bcc0-98a93ff02a2c

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-13T20:29:07Z

💻 [CI Build #0b203a4] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0b203a42f74807738bb65675bbc419420a7cd5a2 [PR build]

Copilot · 2025-06-13T20:29:11Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: fc5298ef-8acc-4733-b86d-db3f2bc11880

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-13T20:32:01Z

💻 [CI Build #0b203a4] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0b203a42f74807738bb65675bbc419420a7cd5a2 [PR build]

Copilot · 2025-06-13T20:32:05Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 70310c08-bad7-4e8f-8bb5-0a03ebb45005

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-13T20:33:02Z

💻 [CI Build #0b203a4] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0b203a42f74807738bb65675bbc419420a7cd5a2 [PR build]

Copilot · 2025-06-13T20:33:06Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: d8f9586f-17ec-484f-89cd-46198b9e61f1

Sorry for the inconvenience!

Initial plan for issue

e9253cb

Copilot AI assigned Copilot and rolfbjarne Jun 13, 2025

Copilot started work on behalf of rolfbjarne June 13, 2025 18:10 View session

Fix FilterStaticFrameworks to support custom framework binary names

0bd54f1

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] FilterStaticFrameworks task doesn't support custom Framework binary names~~ Fix FilterStaticFrameworks task to support custom framework binary names Jun 13, 2025

Copilot AI requested a review from rolfbjarne June 13, 2025 18:23

Copilot finished work on behalf of rolfbjarne June 13, 2025 18:23

mandel-macaque requested changes Jun 13, 2025

View reviewed changes

Copilot started work on behalf of mandel-macaque June 13, 2025 18:32 View session

mandel-macaque requested changes Jun 13, 2025

View reviewed changes

Clean up PDictionary.FromFile usage by removing unnecessary try-catch

d3f208c

Co-authored-by: mandel-macaque <2190086+mandel-macaque@users.noreply.github.com>

Copilot finished work on behalf of mandel-macaque June 13, 2025 18:42

Copilot started work on behalf of mandel-macaque June 13, 2025 18:42 View session

Simplify logical condition to use AND with short-circuiting

0b203a4

Co-authored-by: mandel-macaque <2190086+mandel-macaque@users.noreply.github.com>

Fix FilterStaticFrameworks task to support custom framework binary names #23045

Are you sure you want to change the base?

Fix FilterStaticFrameworks task to support custom framework binary names #23045

Uh oh!

Conversation

Copilot AI commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Solution

Example

Testing

Uh oh!

mandel-macaque Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 13, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 13, 2025

💻 [CI Build #d3f208c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

Copilot AI commented Jun 13, 2025

Uh oh!

Copilot AI commented Jun 13, 2025 •

edited

Loading