[RGen] Generate the aux BlockLiteral pointer variable for the trampolines. #23078

mandel-macaque · 2025-06-18T19:06:33Z

Generates the creation of a BlockLiteral pointer aux variable that will be used to pass a block callback to the invoker.

We are not yet fully doing the convesions needed for a block callback in the native invoker call. We need the following: ```csharp [BindingImpl (BindingImplOptions.GeneratedCode | BindingImplOptions.Optimizable)] unsafe global::AudioUnit.AudioUnitStatus Invoke (ref global::AudioUnit.AudioUnitRenderActionFlags actionFlags, ref global::AudioToolbox.AudioTimeStamp timestamp, uint frameCount, nint outputBusNumber, global::AudioToolbox.AudioBuffers outputData, [BlockProxy (typeof (ObjCRuntime.Trampolines.NIDAURenderPullInputBlock))]global::AudioUnit.AURenderPullInputBlock? pullInputBlock) { var outputData__handle__ = outputData.GetHandle (); using var block_pullInputBlock = Trampolines.SDAURenderPullInputBlock.CreateNullableBlock (pullInputBlock); BlockLiteral *block_ptr_pullInputBlock = null; if (pullInputBlock is not null) block_ptr_pullInputBlock = &block_pullInputBlock; var ret = (AudioUnitStatus) invoker (BlockPointer, (AudioUnitRenderActionFlags*) global::System.Runtime.CompilerServices.Unsafe.AsPointer<AudioUnitRenderActionFlags> (ref actionFlags), (global::AudioToolbox.AudioTimeStamp*) global::System.Runtime.CompilerServices.Unsafe.AsPointer<global::AudioToolbox.AudioTimeStamp> (ref timestamp), frameCount, outputBusNumber, outputData__handle__, (IntPtr) block_ptr_pullInputBlock); GC.KeepAlive (outputData); return ret!; } ``` This change adds the declaration of the 'block_pullInputBlock', we will add the assigment in comming PRs to make the reviews easier.

…ines. Generates the creation of a BlockLiteral pointer aux variable that will be used to pass a block callback to the invoker.

Copilot

Pull Request Overview

This pull request adds functionality to generate an auxiliary BlockLiteral pointer variable for trampolines, enabling the proper handling of block callbacks in the generated code. Key changes include:

Modifying trampoline test cases to include the BlockLiteral pointer variable.
Introducing a new test for BlockLiteral auxiliary variable generation in ObjCRuntime.
Updating generator logic to produce both the nullable block and its corresponding pointer variable.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/rgen/Microsoft.Macios.Generator.Tests/Emitters/BindingSyntaxFactoryTrampolineTests.cs	Updates test expecting the new block pointer variable.
tests/rgen/Microsoft.Macios.Generator.Tests/Emitters/BindingSyntaxFactoryObjCRuntimeTests.cs	Adds a test for the generated BlockLiteral auxiliary variable.
tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/ExpectedTrampolinePropertyTestsTrampolines.cs	Updates expected declarations to verify pointer variable generation.
src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.Trampoline.cs	Modifies trampoline generation logic to include the BlockLiteral auxiliary variable.
src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.ObjCRuntime.cs	Introduces a helper to generate a BlockLiteral pointer variable with proper documentation.

Copilot · 2025-06-18T20:01:24Z

src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.ObjCRuntime.cs

+							SyntaxKind.NullLiteralExpression)))),
+			PrefixUnaryExpression (
+				SyntaxKind.AddressOfExpression,
+				IdentifierName (blockVariableName!)),


Avoid using the null-forgiving operator '!' when accessing blockVariableName in this context. Ensure that blockVariableName is non-null before usage or adjust the logic so that the '!' operator is not needed.

Suggested change

IdentifierName (blockVariableName!)),

IdentifierName (blockVariableName)),

vs-mobiletools-engineering-service2 · 2025-06-18T20:25:08Z

✅ [PR Build #c94d900] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c94d9003ce20993b2a397ecf038ebec53efa074e [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T20:26:18Z

✅ [CI Build #817d581] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 817d5818094cf72ed744c68e32d369e3ca305669 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T21:07:46Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c94d9003ce20993b2a397ecf038ebec53efa074e [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T21:21:40Z

✅ [CI Build #817d581] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 817d5818094cf72ed744c68e32d369e3ca305669 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T21:33:03Z

💻 [CI Build #817d581] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 817d5818094cf72ed744c68e32d369e3ca305669 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T21:34:49Z

💻 [CI Build #817d581] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 817d5818094cf72ed744c68e32d369e3ca305669 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T21:35:36Z

💻 [CI Build #817d581] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 817d5818094cf72ed744c68e32d369e3ca305669 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T21:36:22Z

💻 [CI Build #817d581] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 817d5818094cf72ed744c68e32d369e3ca305669 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-18T21:53:28Z

🚀 [CI Build #c94d900] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c94d9003ce20993b2a397ecf038ebec53efa074e [PR build]

mandel-macaque · 2025-06-18T21:54:47Z

Failing tests are unrelated to code changes.

mandel-macaque and others added 3 commits June 18, 2025 10:36

Auto-format source code

ea5d060

[RGen] Generate the aux BlockLiteral pointer variable for the trampol…

73bc431

…ines. Generates the creation of a BlockLiteral pointer aux variable that will be used to pass a block callback to the invoker.

Base automatically changed from dev/mandel/rgen-trampoline-block-param to main June 18, 2025 19:07

Auto-format source code

d25a5fc

dalexsoto approved these changes Jun 18, 2025

View reviewed changes

Merge branch 'main' into dev/mandel/create-blockliteral-pointer

3a594d1

This comment has been minimized.

Sign in to view

Generate the asigment to use a conditional.

817d581

dalexsoto approved these changes Jun 18, 2025

View reviewed changes

Auto-format source code

c94d900

This comment has been minimized.

Sign in to view

mandel-macaque requested a review from Copilot June 18, 2025 20:00

Copilot AI reviewed Jun 18, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 56d7587 into main Jun 18, 2025
38 of 40 checks passed

mandel-macaque deleted the dev/mandel/create-blockliteral-pointer branch June 18, 2025 21:54

	IdentifierName (blockVariableName!)),
	IdentifierName (blockVariableName)),

[RGen] Generate the aux BlockLiteral pointer variable for the trampolines. #23078

[RGen] Generate the aux BlockLiteral pointer variable for the trampolines. #23078

Uh oh!

Conversation

mandel-macaque commented Jun 18, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2025

✅ [PR Build #c94d900] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 18, 2025

✅ [CI Build #817d581] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2025

✅ [CI Build #817d581] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2025

💻 [CI Build #817d581] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 18, 2025

💻 [CI Build #817d581] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 18, 2025

💻 [CI Build #817d581] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 18, 2025

💻 [CI Build #817d581] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2025

🚀 [CI Build #c94d900] Test results 🚀

Test results

Tests counts

Uh oh!

mandel-macaque commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!